This repository was archived by the owner on Nov 15, 2023. It is now read-only.
babe: remove error fallback from threshold calculation#5764
Merged
Conversation
andresilva
added
A0-please_review
kirushik
approved these changes
Apr 23, 2020
Contributor
Author
|
We should do a full resync of kusama with this patch to make sure that the given assumptions weren't violated so far. |
bkchr
approved these changes
Apr 23, 2020
stanislav-tkach
approved these changes
Apr 23, 2020
rphmeier
approved these changes
Apr 23, 2020
Contributor
is this pending prior to a merge? I've set the tags accordingly, otherwise feel free to merge. |
gnunicorn
added
A3-in_progress
Contributor
Author
|
Just started a Kusama sync with this PR, #5501 and #5514 (Wei had already tested those though). It will still take a while to sync everything from scratch, so if you prefer we can merge this optimistically and revert in case something broke (it shouldn't but I just want to make sure all the invariants actually hold). |
Contributor
Author
|
Sync completed, no issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing the primary threshold calculation in BABE we default to returning
u128::max_value()in case any error happens in intermediary computations. The computations should not fail and instead "proofs" are given in expects.Fixes #5753.